On 08/13/2012 01:48 PM, Michael Meeks wrote:
IMHO I'd prefer to have an RC3 for 3.6.1 than the potential for
regression by including this in 3.6.2 - and having the state-of-the-art
code that is shared between master and -3-6 for testing seems sensible
(to me).
In the end, I'd be fine either way. An additional review might make
sense when integrating it now.
The only gotcha I spotted was the:
@@ -222,18 +211,6 @@ NodeJava::NodeJava(Layer layer):
constructor; but it seems we initialize m_layer earlier already so just
remove a duplicate initialization.
Yes, the removed else-branch was redundant.
Stephan
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.