Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Ivan Timofeev píše v St 08. 08. 2012 v 22:58 +0400:
Hi,

https://bugs.freedesktop.org/show_bug.cgi?id=50654
"Writer, Ruler: Paint issue at bottom left-ruler"

http://cgit.freedesktop.org/libreoffice/core/commit/?id=84d5e639b08a1f96b41b7b5b6af51c703b0cd620
fixes it, the commit message explains all.

And although it is maybe just a cosmetic issue, it would be great to 
have the fix in 3-6 (where everyone looks to the rulers now :) and 
possibly in 3-5(?)

It looks sensible and works => pushed into both branches:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=1500bc8970dc61f96697a186d6bb0d1aacc2ce67
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=6f86c8e38a5263e609ec189b2a01d4fad7cd0e4e


BTW: I wonder if we could remove the duplicated code from
Ruler::Resize(). It calls ImplInitExtraField just few lines above. I am
not 100% sure but it seems that the code in between does not affect
mnVirWidth and the other variables. It does not make sense to call it
twice. It might be enough to do this clean up in master.

Thanks a lot for digging into it.



Best Regards,
Petr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.