Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


From Björn Michaelsen <bjoern.michaelsen@canonical.com>:

Björn Michaelsen has uploaded a new change for review.

Change subject: fix WhichRange management in SfxItemSet
......................................................................

fix WhichRange management in SfxItemSet

* Remove SetRanges() function
  - has always been misleading and easy to abuse
* dont use naked new/delete memory allocation for the WhichRanges
* use a scoped_ptr to a std::vector for the ranges instead
  - also use stl algorithms were possible
* add lots and lots of SAL_WARN/SAL_INFO goodness
* add lcl_PrintItemSet() debug function
* finally kill off the abomination call nranges

Change-Id: Ie702c37152097a0012e76c630712b6ea37b7f9dc
---
M svl/Package_inc.mk
M svl/inc/svl/itemset.hxx
D svl/inc/svl/nranges.hxx
M svl/source/items/itemset.cxx
D svl/source/items/nranges.cxx
5 files changed, 301 insertions(+), 1,169 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/367/1
--
To view, visit https://gerrit.libreoffice.org/367
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie702c37152097a0012e76c630712b6ea37b7f9dc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen@canonical.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.