Re: [PATCH] Native background for some more widgets

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Wed, 25 Jul 2012 22:56:23 +0400

Hello Ruslan,

On 12.07.2012 14:50, Ruslan Kabatsayev wrote:

These patches make TabBar and ToolBox have correct native background
(needed for bg gradients and other non-flat-colored backgrounds).

this patch a bit breaks a toolbar look to me. (on Linux, the defaultUbuntu's Ambiance theme, have not tried on windows, where it is nowcompletely broken I guess).


vcl/source/window/toolbox.cxx:575:

// toolbars known to the dockingmanager will be drawn using NWF or agradient// docked toolbars are transparent and NWF is already used in thedocking area which is their common background

 // so NWF is used here for floating toolbars only

So I'd revert that change it toolbox.cxx. Opinions?

Regards,
Ivan

Context

[PATCH] Native background for some more widgets · Ruslan Kabatsayev
- Re: [PATCH][PUSHED] Native background for some more widgets · Caolán McNamara
  - Re: [PATCH][PUSHED] Native background for some more widgets · Ruslan Kabatsayev
- Re: [PATCH] Native background for some more widgets · Ivan Timofeev
  - Re: [PATCH] Native background for some more widgets · Ruslan Kabatsayev

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.