On 24/07/12 11:27, Petr Mladek wrote:
David Tardon píše v Út 24. 07. 2012 v 10:26 +0200:On Tue, Jul 24, 2012 at 10:11:21AM +0200, Stephan Bergmann wrote:<https://bugs.freedesktop.org/show_bug.cgi?id=51659> "File >> Wizards >> Letter Yields No UI" had apparently independently been fixed on master already with Caolan's <http://cgit.freedesktop.org/libreoffice/core/commit/?id=18b15e48cb1fa7590620930975796a0c0dcac225> "this is the stupidest hard-coded number in the world," but it also requires backporting to libreoffice-3-6 and libreoffice-3-6-0. I backported it to libreoffice-3-6 with my sign-off now as <http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=67db4e1ec90161bc31c00bc67190bc2895c7fa59>. Two more reviews for this trivial fix are needed for libreoffice-3-6-0.+1 from me. One more needed.Great catch. Works well => +1 => pushed into 3-6-0 branch.
to prevent this particular ridiculous problem from happening again on master i've just added a static assertion: http://cgit.freedesktop.org/libreoffice/core/commit/?id=117fb70532aeae01327bfe0d828ef8a2d4793b85 unfortunately the BOOST_STATIC_ASSERT_MSG doesn't seem to be available in the internal boost version, but hopefully people will look up the source if they get a weird compile error :)