Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor

Stephan Bergmann <sbergman -AT- redhat.com>
Mon, 23 Jul 2012 17:28:41 +0200

On 07/23/2012 04:40 PM, Michael Stahl wrote:

On 22/07/12 11:25, Kristian Rietveld wrote:

(Please keep me on CC as I am not subscribed to the list)

[...]

that is really not supposed to happen, we really should build everything
with -fvisibility=hidden on all platforms where unnecessarily exported
symbols cause such problems (guess that means everything but Windows).

on master and libreoffice-3-6, in solenv/gbuild/platform/macosx.mk the
-fvisibility=hidden is inside:

ifeq ($(HAVE_GCC_VISIBILITY_FEATURE),TRUE)


can you check that that is actually detected properly for your compiler?

Explicitly disabled for Clang on Mac OS X in configure.in, see<http://cgit.freedesktop.org/libreoffice/core/commit/?id=e5143062887093037cab8f936288af8408576ea8>"Visibility doesn't seem to work as we want in Apple's Clang." :(


Stephan

Context

[PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Kristian Rietveld
- Re: [PATCH][PUSHED] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Caolán McNamara
- Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Michael Stahl
  - Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Stephan Bergmann
    - Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Michael Stahl
      - Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Tor Lillqvist
    - Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Stephan Bergmann
      - Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Michael Stahl
        
        Re: [PATCH] Fix for sw_filter_test crash due to ambiguous FieldEntry destructor · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.