Stephan Bergmann píše v Po 23. 07. 2012 v 18:26 +0200:
On 07/23/2012 05:12 PM, Michael Meeks wrote:
Norbert's trace with bugs suggested a great site for the source of
this; an unfortunately outdated copy of listeners that can be emitted
after they are removed. This simple patch uses the list copy for safe
iteration, while checking the parent listener is still registered. At
least, I hope it does ;-)
kudos to Norbert for managing to reproduce it on a build with symbols.
2x extra reviews much appreciated to take it to -3-6-0:
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=222b7032153cfd3a6f5e12e2fc855ccabc2ea769
Of course, it is -possible- that continuing to emit listener that have
been already removed is required by some dark corner of the code (if so
it is prolly best to find it sooner rather than later).
+1 from me
Yup, it looks reasonable and safe => pushed into 3-6-0 branch.
Best Regards,
Petr
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.