Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 23/07/12 17:41, Caolán McNamara wrote:
So rsvg_handle_new_from_data calls rsvg_handle_close already it turns
out. In new versions of librsvg you can call rsvg_handle_close on a
handle safely as many times as you want, but in older versions like that
of RHEL-5 you can only call it once.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=682cb83ed59233decbeeaff68c4d871442b58bb1

i.e. just drop rsvg_handle_close because rsvg_handle_new_from_data
already did it

i was wondering why you'd removed the content of the then branch until i
realized that that is actually error handling code for a failed close
call... it's really painful to read code with 2 side effects in the if
clause....

pushed to libreoffice-3-5. libreoffice-3-6

2 more necessary for -3-6-0



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.