Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

Michael Meeks <michael.meeks -AT- suse.com>
Mon, 23 Jul 2012 15:28:24 +0100


On Mon, 2012-07-23 at 15:53 +0200, Jan Holesovsky wrote:

would some two people please review & then cherry-pick
 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bfba6ee21b5576c9da475b13d7db0f735f078d2


Thanks so much for that! - looks great to me; we should probably remove
the AquaSalGraphics::GetGlyphBoundRect() so that it does not confuse
others too, right? :-)
1 more review + cherry-pick still needed.


        +1 from me - it simply duplicates the equivalent code [cough] from
DrawText - right ? ;-)

        Regards,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot

Context

[REVIEW-3-6-0] Fix vertical rulers on MacOS · Thorsten Behrens
- Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Jan Holesovsky
  - Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Michael Meeks
    - Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Thorsten Behrens
  - Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Thorsten Behrens
    - Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Norbert Thiebaud
      - Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS · Norbert Thiebaud
        
        Re: [PUSHED 3-6-0] Fix vertical rulers on MacOS · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.