Re: [PATCH (partial)] fdo#48549 System::Beep() removal

Hey,

2012/7/23 Mathieu Vonlanthen <mat_von@fastmail.fm>:
> Hi,
> Here is my license statement:
> -----
> All of my past & future contributions to LibreOffice may be licensed
> under the MPL/LGPLv3+ dual license.
> ------
> I send a new version of the patch taking into account the last commits.
> I didn't add error reporting because I don't know the official way to do
> this.
>
> Best regards
>
> Mathieu Vonlanthen

Thank you very much for your work! Having reviewed your patch, I still
think that a warning/logging might be helpful for latter debugging in
the following files:

* basctl/source/basicide/baside2.cxx
  - @@ -572,9 +571,6 @@ sal_Bool ModulWindow::ToggleBreakPoint(
sal_uLong nLine )
  - @@ -790,10 +782,7 @@ void ModulWindow::BasicAddWatch()
  - @@ -1022,10 +1011,6 @@ void ModulWindow::ExecuteCommand( SfxRequest& rReq )
* basic/source/runtime/methods.cxx
* formula/source/ui/dlg/funcutl.cxx
* sc/source/ui/app/inputhdl.cxx
* sc/source/ui/docshell/olinefun.cxx
* sc/source/ui/navipi/content.cxx
* sc/source/ui/navipi/navipi.cxx
* sc/source/ui/view/viewfun2.cxx
* sc/source/ui/view/viewfun6.cxx
* svtools/source/edit/textview.cxx
* svx/source/form/tbxform.cxx
* svx/workben/edittest.cxx
* sw/source/ui/utlui/content.cxx

But I do not know what the general opinion of the LO developers for
that cases is... Maybe they are happy without any logging in there...
Whould love to hear from the others what they think.

Nevertheless, removing that annoying beeps is a good thing!

Cheers,
Philipp