Re: Modern font features, hacky patch

On Sat, Jul 21, 2012 at 09:51:09PM +0200, Matúš Kukan wrote:
> On 21 July 2012 18:20, Khaled Hosny <khaledhosny@eglug.org> wrote:
> > Here is a very crude, WIP patch. It adds --enable-harfbuzz configure
> > option, plus some (very broken) harfbuzz layout code, but I can't get
> > the ENABLE_HARFBUZZ to propagate in and thus can't do any testing
> > because the code is never compiled. I appreciate any insights on how to
> > get this to work.
>
> +export HARFBUZZ_FLAGS=@HARFBUZZ_CFLAGS@
> should be
> +export HARFBUZZ_CFLAGS=@HARFBUZZ_CFLAGS@
>
> You want to add:
> +$(call gb_LinkTarget_add_defs,$(1),\
> +    -DENABLE_HARFBUZZ \
> +)
> into RepositoryExternal.mk
> and use it as
> +$(eval $(call gb_Library_use_externals,vcl,harfbuzz))
> in vcl/Library_vcl.mk

I tried this already but didn't work, now I why, thanks.

Regards,
 Khaled