Hi Eike,
On 16 July 2012 15:16, Eike Rathke <erack@redhat.com> wrote:
Hi Matúš,
On Saturday, 2012-07-14 19:49:29 +0200, Matúš Kukan wrote:
What's wrong:
- TeleManager is never destroyed.
Because I don't know where.
I think ScDocFuncSend and/or ScDocFuncRecv could hold a pointer they
obtained from TubeContacts and call TeleManager::unref() when destroyed.
Make sure TubeContacts passes the pointer by calling TeleManager::get()
to increment the reference count and unrefs any instance it obtained via
get() itself.
Not really.
I think that we may want TeleManager to live when there is no document yet.
Definitely before some document is shared, so before ScDocFuncSend.
The code in TubeContacts is wrong btw.
Imagine that we install .service .client files and somebody wants to
share a file with us for collaboration.
Channel dispatcher runs ./soffice --accept-tube and some code in
desktop/ starts TeleManager which receives the file, incoming channel
and sets the collaboration.
If we want this.
Matus
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.