Hi Caolán,
Thank you for your review!
On Sun, 15 Jul 2012 08:43:38 +0100, Caolán McNamara <caolanm@redhat.com> wrote:
On Sun, 2012-07-15 at 08:32 +0900, Takeshi Abe wrote:
Having reproduced fdo#52013 on master, I would like to ask for a favor of reviewing
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b689371cc344f14af783f87c7fe37f5350c10ab
for 3.6.
Seems to me that the original conversion of
9c0ca924446933431d736ee0dd37e6852b4947dc should have used vector::insert
rather than std::copy ?, i.e. like the attached
Exactly, I stand corrected.
Please push it to master, and do we need another ack for the 3.6 branch?
Cheers,
-- Takeshi Abe
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.