Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

according to my understanding,

OUString::compareToAscii(RTL_CONSTASCII_STRINGPARAM("A string")) gives exactly the same result as
OUString::compareToAscii("A string")

However, the first one:
    - is harder to read
    - uses the deprecated RTL_CONSTASCII_STRINGPARAM macro
    - is a bit slower

If you agree with that, I will provide a patch to clean it.



Moreover, and as a 2nd step, I plan to propose a patch that turns:
    s.compareToAscii("A string") == 0
into
    s.equalsAscii("A string")

and

    ! s.compareToAscii("A string")
into
    s.equalsAscii("A string")

I think that equalsAscii is better because:
    - shorter
    - more meaningful
    - doing some ! on sal_Int32 is not as clean as using sal_Bool directly

Do you think that such a clean-up is interesting ?

Best regards,
Christophe Jaillet


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.