[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported

Korrawit Pruegsanusak <detective.conan.1412 -AT- gmail.com>
Tue, 10 Jul 2012 20:59:37 +0700

Hello all,

First, sorry for not using gerrit. I've tried it but got "invalid
author" error as I tried to push Muthu's patch.

The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907
on master, so I propose this review for the inclusion in both -3-6 and
-3-5 branches.

Branch -3-5 didn't apply cleanly, because conflict by getLength() to
isEmpty() change, so patch attached, for both branches. I also deleted
code-indent change, which is already in master, in
oox/source/ppt/pptshapegroupcontext.cxx.

Last, sorry to say this, but I didn't have time to test if it could be
build or even fix the problem. (I didn't test in both branches, but
tested in master that this really fixes the problem, please see
comment 11 in fdo bugzilla).

Thanks :-)
Best Regards,
-- 
Korrawit Pruegsanusak

Attachment: 0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-5.patch
Description: Binary data

Attachment: 0001-n-759210-Certain-smartart-drawings-weren-t-imported-3-6.patch
Description: Binary data

Context

[REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported · Korrawit Pruegsanusak
- Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported · Korrawit Pruegsanusak
  - Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported · Korrawit Pruegsanusak
  - Re: [PUSHED 3-6, 3-5] n#759210: Certain smartart drawings weren't imported · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.