Hi Michael,
Threadbreaking for visibility and topic change. We are talking about the gerrit
to dev-list firehose.
Michael Meeks wrote:
Hmm; I'd want to capture substantive reviews really; but - I guess this is
better for now.
The tricky question is: what is a 'substantive review'? Some Ideas:
1) By score
A substantive review has at least:
- verfied -1 (Fails)
- or a code-review=-1,-2 or +2
Everything else (esp. +1 verified or only code-review=0,1) are not copied to the list
2) By keyword
A substantive review is on which contains the keyword "copytodevlist".
3) By heuristic
Do something with wordcount and other fancy stuff.
I find solution 2 kinda neat in its pragmatic approach.
It'd be really nice to extract the important [PUSHED] style information into
the Subject so it's easy to immediately see & junk a thread that was handled
already - if that's possible. Thanks !
Should be done now. I removed the "Change in core[master]" boilerplate and
added '[PATCH]' and '[PUSHED]' as appropriate. If we want to have it more fancy
we could do virtually everything with
http://gerrit.googlecode.com/svn/documentation/2.1.2/cmd-stream-events.html
but the hard part is coming up with a sensible definition what we (as a
community of devs) want. The last time we discussed that it ended in 'send
everything to the list', which proved suboptimal in the end. So some more
frontup work needed there.
Best,
Bjoern
Context
- gerrit lame / non-reviews spammage · Bjoern Michaelsen
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.