Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


From Korrawit Pruegsanusak <detective.conan.1412@gmail.com>:

Korrawit Pruegsanusak has posted comments on this change.

Change subject: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not match()
......................................................................


Patch Set 1:

I don't know if other filters, apart from ppt, should use match() or indexOfAsciiL(). I have no 
time to test them, sorry. So, I prefer this safer way -- rolling back to the equivalent of 
SearchAscii().

Also, I'm a bit reluctant between indexOfAsciiL() >= 0 and != -1, which means "not found". Which is 
better?

This should be pushed to -3-6 branch as well. Thanks :-)

--
To view, visit https://gerrit.libreoffice.org/264
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c3160be1c61162f6a62a7e14c4efb7bedccdcc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak <detective.conan.1412@gmail.com>
Gerrit-Reviewer: Korrawit Pruegsanusak <detective.conan.1412@gmail.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.