Re: [PUSHED][PATCH] build problem with gcc 4.5.2

Hi,

On 07.07.2012 18:10, Terrence Enger wrote:
> Around 2012-07-07 00:45 UTC, I pulled master commit 2758492 and tried
> to build on ubuntu-natty (11.04), which has gcc version 4.5.2.  The
> gcc compiles downstream from files cfglex.l, xrmlex.l, and srclex.l in
> l10ntools/source/ each failed with the message
>
>      error: unknown option after ‘#pragma GCC diagnostic’ kind
>
> Each time, the offending line was
>
>      #pragma GCC diagnostic ignored "-Wunused-but-set-variable"
>
>
> Taking a hint from <https://lkml.org/lkml/2011/7/26/488>, I
> conditioned the three lines by
>
>      #if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6))
>
> which allows a successful build.  I attach a patch, just in case this
> situation of interest and this is the right solution; my blanket
> licence statement is on file.
Pushed, thanks for that!
The problem was introduced during gbuild'ification of l10ntools module.
We changed it from wrapping to using the generated files directly
(we used ignore system header instead of diagnsoric pragma).

I extended your patch and added the "-w" option to hide these ugly flex 
warnings.
I forgot it during gbuildi'ification ;-)

May I kindly ask you to use in future our new Code Review System gerrit:
https://gerrit.libreoffice.org/
instead of sending patches to dev ML?
You can find the infos how to register, configure and use it here:

https://wiki.documentfoundation.org/Development/gerrit/setup
https://wiki.documentfoundation.org/Development/GitReview

If you have questions or want provide feedback, you can ask on ML
or catch gerrit guys on IRC: Sweetshark, shm_get and reinsle.

Regards
David