From Thorsten Behrens <thb@documentfoundation.org>:
Thorsten Behrens has posted comments on this change.
Change subject: fdo#35365 Set the default font color to black and the document color to white.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks good, either push as-is & do the rework onwards, or update patch
....................................................
File svtools/source/config/colorcfg.cxx
Line 465
This looks fine to me
Line 473
This needs some work - I find a few more occasions of FONTCOLOR in svx/source/*, apparently used in
UI code - I suggest to convert that over to explicit
Application::GetSettings().GetStyleSettings().GetWindowTextColor() there?
--
To view, visit https://gerrit.libreoffice.org/238
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Gerrit-Reviewer: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Gerrit-Reviewer: Jan Holesovsky <kendy@suse.cz>
Gerrit-Reviewer: Thorsten Behrens <thb@documentfoundation.org>
Context
- Change in core[master]: fdo#35365 Set the default font color to black and the docume... · Gerrit
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.