Re: [PATCH] [REVIEW:3-5,3-6] size optimisation

Hi Lionel,

On Tue, 2012-07-03 at 20:33 +0200, Lionel Elie Mamane wrote:
> I'm unsure whether I should apply this to libreoffice-3-6 or maybe
> even libreoffice-3-5; I'd be glad of your opinions.

        Sounds reasonable for -3-6 to me (but doesn't require approval there as
a bug fix:-).

> This patch tells HSQLDB, on each flush, to "defrag" the database. This
> can take time for big databases :-| and will happen at least for each
> file save operation.

        I would add a magic env-var to turn that on/off - so people can (at a
pinch) disable it if need be (and we can isolate it's effect better).

> The alternative would be to introduce an UI element
> "compress/cleanup/defrag database", but:
>
> 1) It would necessarily be specific to sdbc(x) direct drivers as AFAIK
>    odbc / jdbc / ... don't have a standard way to do such an
>    operation.

        :-)

> 4) More work, and touching the UI, so I won't do it by myself. If we
>    decide it is the better idea and someone wants to collaborate on
>    that...

        We could add an easy hack or something. If we could abstract the
hoovering in some nice way in the code, so this is possible later, I'd
be happier - but - you're the boss in base :-)

        So - I'd just go for it, and wait for user feedback during 3.6 beta.

        Thanks !

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot