Re: [REVIEW 3-5-6] resolved fdo#51601 do not attempt to compile running formula cell

Petr Mladek <pmladek -AT- suse.cz>
Tue, 03 Jul 2012 12:12:07 +0200

Eike Rathke píše v Út 03. 07. 2012 v 11:22 +0200:

Hi,

Please review attached patch for 3-5-6
It is a quick fix for https://bugs.freedesktop.org/show_bug.cgi?id=51601


It solves the crash here. The comment warns about the crash, so the
operation was indeed dangerous. It did not crash that often, so this
code is probably used only rarely => probably small loss in the import
quality. I prefer to have it more stable => I am for this fix.

We need two more approvals for 3-5-5 branch. I would like to hear from
Markus or Muthu.


Best Regards,
Petr

Context

[REVIEW 3-5-6] resolved fdo#51601 do not attempt to compile running formula cell · Eike Rathke
- Re: [REVIEW 3-5-6] resolved fdo#51601 do not attempt to compile running formula cell · Noel Power
- Re: [REVIEW 3-5-6] resolved fdo#51601 do not attempt to compile running formula cell · Petr Mladek
- Re: [REVIEW 3-5-6] resolved fdo#51601 do not attempt to compile running formula cell · Muthu Subramanian K
- Re: [PUSHED 3-5 3-5-5] resolved fdo#51601 do not attempt to compile running formula cell · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.