Re: [PUSHED] Re: [PATCH] cleanup java code and update to Java5, including generics (36)

On Fri, Jun 29, 2012 at 10:07 PM, Michael Stahl <mstahl@redhat.com> wrote:
> [PATCH 22/36] Java5 update - convert code to use generics
> [PATCH 36/36] Java5 updates - update code to use generics
>
> the above 2 patches seem to change interfaces of classes in "ridljar"
> and "javaunohelper" that are likely part of the stable URE ABI, and
> shouldn't be changed; i think adding type parameters is OK (after all
> the Java standard libraries had these retrofitted as well, and they
> don't exist at runtime anyway thanks to type erasure) but things like
> replacing Hashtable with Map is not OK, so i've reverted those parts.

It should be fine to convert Hashtable to Map in parameters of methods
because Hashtable implements Map.
I'll go over those patches again on Monday and produce a reduced set
that doesn't impact the API.


Regards, Noel.