Hellp Philipp
2012/6/28 Philipp Riemer <ruderphilipp@gmail.com>:
Hey Markus, Michael, all,
Two minor things from my side as a newbie to the LO project:
(1) In lines 288-291 of the patch you also delete the comment showing
from where you got the CPPUNIT file. Might be helpful to keep the
URL...
The URL is wrong now. Our cppunit version is from
http://cgit.freedesktop.org/libreoffice/cppunit/log/ so I don't think
that we need this URL now.
(2) In addition, I was wondering why the install folder is still
"ooo-install" in the makefile (lines 321-257)? Backward compatibility
reasons?
Why should we make a riskful change to something that is clearly
working as it should. IMHO changing internal names without a good
reason is not a good idea.
Patches is already pushed because Michael needed it for his rebasing.
Regards,
Markus
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.