Re: [PUSHED 3-5][REVIEW 3-5-5] Fix fdo#48602: code-page mismatch in Visio 2000 files

Fridrich Strba píše v Pá 22. 06. 2012 v 12:37 +0200:
> On 22/06/12 12:25, Fridrich Strba wrote:
> > Dearest co-contributors,
> >
> > Could you review and cherry-pick for me:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c2843d807c15452a5b03ec8287d4f1c1ed35b01
> >
> > It is a new version of libvisio that consolidates the patched in
> > libvisio modules fixing various crashes. It also implements the
> > conversion of different 8-bit MS code-pages to UCS4 and thus fixes the
> > code-page mismatch from fdo#48602.
> >
> > This release also incorporates some innocent cppcheck fixes from Julien.
>
> For reviewer, here is a full diff between libvisio 0.0.17 and libvisio
> 0.0.18 http://pastebin.com/fp8zj5Mz

Thanks for the diff. It was pretty useful. I do not pretend that I
checked every single word. Anyway, I did not see anything crazy. I know
that you test things carefully. Also the code affect only the Visio
import => low risk => pushed:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=949c6d959af1971552ae78e69251fab1b8e7dce3

Two more approvals are needed for 3-5-5.

Best Regards,
Petr