Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hey,
I checked every file that was touched by commit
ec5fa0164b9bae5c5bc6654f581e493206584301 by hand and created a patch
that deletes all duplicates I could find.

Cheers,
Philipp

2012/6/21 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
Le 21/06/2012 22:52, Michael Stahl a écrit :

On 21/06/12 22:44, Christophe JAILLET wrote:

Looking at the last commit :

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ec5fa0164b9bae5c5bc6654f581e493206584301

we can see that "replacing .hdl include with equivalent .hpp includes"
leads to duplication of some includes.

For example in filter/source/svg/svgfilter.cxx

<http://cgit.freedesktop.org/libreoffice/core/tree/filter/source/svg/svgfilter.cxx?id=b326c1d728e65afea4257d1142a02185ae6bc4d0>,
we now have :

 >>>>>>>>>>>>>
#include <com/sun/star/view/XSelectionSupplier.hpp>
#include <com/sun/star/view/XSelectionSupplier.hpp>

oh, good catch, can you send a patch to clean these up?  :)

I will not have time in the coming days to check all the modified files.
I've forwarded my mail to the committer of the patch with the hope he would
do it by himself :)

Attachment: 0001-cleanup-of-duplicated-includes.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.