Re: [Libreoffice] [GSoC 2012][svg export filter] support of 'dur' attribute for time containers

On Thu, 21 Jun 2012 00:21:08 +0200, Thorsten Behrens  
<thb@documentfoundation.org> wrote:

> Marco Cecchetti wrote:
> > The final jump is due to the fact that the "deactivate" method of
> > an animation node invokes the managed activity "end" method that
> > in turn calls "performEnd" which evaluates the animation by passing
> > the final time value (usually 1.0, or 0.0 if the animation is
> > reversed).
> >
> > By commenting out the call to the "performEnd" method the duration
> > attribute on the <par> time container is handled correctly and
> > I can't see any side effect for usual animations.
> Hi Marco,
>
> the bug along which this got added is
> https://issues.apache.org/ooo/show_bug.cgi?id=45197 - please try
> that scenario. Then again, the comments in those performEnd methods
> suggest it might not be the final solution. ;)

I read it. After some test I can add another example where performEnd
makes a difference:

1) create one shape
2) add a custom effect to the shape (e.g. fade in)
3) add a second custom effect to the shape (e.g. change fill color)
   which is played together with the previous one but it is longer
4) start the animation
5) after one second skip to the next animation (left click)

The final state is the following one:
the shape is wrongly shown with only the first effect applied


> > However I'm wondering if it is worth to perform such a modification
> > in order to be more conforming to SMIL when such a feature is never
> > used. Moreover even if I can see no side effect by removing the call
> > to the "performEnd" method, I'm also sure that has been placed there
> > for some good reason (can anyone help me here ?)
> Would love to have it (properly) fixed - see above. :)

I have a problem: I can't hear any sound effect at all.
I got the following message on the standard error:

Message: don't know how to handle audio/x-wav

So I'm not able to perform any test.

Any hint ?

-- Marco


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/