Re: [Libreoffice-commits] .: lo-commit-stat: avoid problems whit '%' in the commit message

On Wed, 2012-06-13 at 10:35 +0200, Stephan Bergmann wrote:
> On 06/12/2012 07:48 PM, Petr Mladek wrote:
> > commit 2e353b8daadc588b02fe7c7df5b7f185187e9d58
> > Author: Petr Mladek<pmladek@suse.cz>
> > Date:   Tue Jun 12 19:46:42 2012 +0200
> >
> >      lo-commit-stat: avoid problems whit '%' in the commit message
> >
> >      Change-Id: Ia10bac649cc078f6ef39002d280dcff7e5d0b06d
> >
> > diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
> > index 310548e..1a8e6bb 100755
> > --- a/bin/lo-commit-stat
> > +++ b/bin/lo-commit-stat
> > @@ -80,6 +80,9 @@ sub standardize_summary($)
> >           my $first_char = lc($1);
> >           $line =~ s/^./$first_char/;
> >       }
> > +    # print does not like 0% or so
> > +    $line =~ s/%/%%/g;
> > +
> >
> >       # FIXME: remove do at the end of line
> >       #        remove bug numbers
>
> lo-commit-stat should better generally use print instead of printf with 
> potentially improper format strings, right?

Ah, shame on me. The C-language is deep in my head.

Stefan, thanks for explaining the mystery.
Also thanks Thorsten for fixing it faster than me.

Best Regards,
Petr