[PUSHED] Re: [PATCH} more SV_DECL_PTRARR conversions

On 12.06.2012 18:20, Noel Grandin wrote:
> Hi
>
> These patches converts various SV_DECL_PTRARR stuff to std::set and 
> std::vector and boost::ptr_vector in various modules
>
> Passes "make check" at global level, and compiled with debug=true

pushed, thanks.

a bunch of your patches do this:

>  typedef ::com::sun::star::uno::Reference<
> -            ::com::sun::star::util::XRefreshListener >* XRefreshListenerPtr;
> -SV_DECL_PTRARR_DEL( XRefreshListenerArr_Impl, XRefreshListenerPtr, 4 )
> +            ::com::sun::star::util::XRefreshListener > XRefreshListenerRef;
> +typedef boost::ptr_vector<XRefreshListenerRef> XRefreshListenerArr_Impl;

a ptr_vector<Reference<XFoo>> is, while not technically wrong, kind of
silly; but you've added these in Calc so i don't care that much :)

patch #16 SbCompare_UString_PropertyValue_Impl doesn't look like a
strict weak ordering to me; while looking at that noticed pre-exiting
problem that the GetIndex_Impl return value is not checked...

patch #21 SfxFilterPtrArr turns out to be unused actually