Hi Winfried, On Saturday, 2012-06-09 12:54:27 +0200, Winfried Donkers wrote:
Attached is the modified patch for function XOR, this time under its own bug.
Thanks, works!
I tested the patch, did an export to xls, reread the xls (XOR calls were not recgnised/calculated when importing),
There's also saFuncTable_Odf in sc/source/filter/excel/xlformula.cxx that still had the ocNoName opcode assigned, that table is used during binary import. Changing the opcode to ocXor solved that.
saved again as ods and reread that one (XOR calls were calculated correctly). I think this has to do with XOR being in saFuncTableOdf[] (in core/sc/source/filter/oox/formulabase.cxx), which has the description "Functions defined by OpenFormula, but not supported by Calc or by Excel." and where XOR _is_ supported by Calc.
Well, that table is inclusive OR ;-) not present in one or the other.. The tricky part is that functions of those aFuncTableOdf entries can be read anyway even if not supported, just may map to an "unknown macro". I also removed the leftover entry from saFuncTableBiff5.
Subject: [PATCH] fdo#50822 add function XOR to calc as in ODFF1.2
um.. yeah, typo in bug number so the commits were assigned to the wrong bug.. manually added to fdo#50882 So, we got this in: http://cgit.freedesktop.org/libreoffice/core/commit/?id=033cce3e0fbb72a9400836923be96c5036aaacb0 For my changes see http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ae96127e5b363e6eea14a0e9459b22f0f7307ca Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
pgpUitlpS_mZU.pgp
Description: PGP signature