Re: IsOfficeRunning() (was: [tdf-core] I'm sure this is an accident...)

> After some research I found that IsOfficeRunning() is completely useless. At
> least in main installer. It checks if (Libre)Office is running, and if it
> is, installer aborts. Originally it tried to rename a file in the
> installation folder with user privileges - instant fail on Vista and Windows
> 7. Now it checks if soffice.bin is running. However, soffice.bin can belong
> to AOO, Symphony etc. that we have no business with. We could fix
> IsOfficeRunning() so it detects LibreOffice only. But why bother? Installer
> will not let overwrite files in use anyway. It will display a dialog that
> user installer needs to update files in use, and it will list the affected
> processes. It is more reliable, than IsOfficeRunning(). If user ignores the
> files in use warning, no problem, things will get sorted out after a
> restart.

I second your opinion.
The worst case scenario is quite unlikely to happen and it's not that
bad in any case.
And there have been way too many people who can't install LibreOffice
on Windows because of this detection.

> My proposal is to remove IsOfficeRunning custom action from installer, and
> delete it from source code. Does anybody know why it was developed in the
> first place?

There might be many reasons, like installation repair, parallel
installations, etc. But i am just guessing here.

-- 
Jesús Corrius <jcorrius@documentfoundation.org>
Deputy of the Board of Directors
The Document Foundation, Zimmerstr. 69, 10117 Berlin,Germany
Rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint