Re: [PUSHED 3-5] fix xlsx height import

The patch looks reasonable

f.

On 08/06/12 12:58, Noel Power wrote:
> There are two problems addressed here
> firstly for the xlsx importer like the xls importer we really don't want
> to call UpdateAllRowHeights ( which autocalculates row heights ),
> currently when the api property IsAdjustHeightEnabled set to true it
> calls UpdateAllRowHeights. This doesn't live up to the spirit of the
> name of the property and also it is counter productive. ( Note: this api
> property was only created for the filter in the first place because of
> the way the uno api triggers potentially triggers UpdateAllRowHeights
> during import )
> Secondly row heights that are specified but that are not marked as
> custom heights are mostly ignored this results in wrong row heights in
> imported documents ( and subsequent layout problems ) ( see
> https://bugs.freedesktop.org/attachment.cgi?id=60991 from fdo#49430
> where Row 2,5,6 etc. are imported at 4.69mm without the patch compared
> to 5.03mm which is what is imported from
> https://bugs.freedesktop.org/attachment.cgi?id=60994 ( the xls version
> of the same document ). Additionally there are documents from  attached
> to i#94028 &  i#93609 which don't currently behave well that this patch
> seems to fix ( but as ever happy for a second opinion )
>
>
> patch attached is a squash ( and backport ) of
> master:764752f5d85cb7c86ad21340dfdda4b62754790c &
> master:1cdfe7519a94d35f3fb47eed3331397cc11129b5
>
> thanks,
>
> Noel
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice