Re: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

Hi Daniel,

trying to send it to once time again.

Regards
David

On 08.06.2012 01:35, Daniel Bankston wrote:
> On 06/07/2012 05:05 PM, David Ostrovsky wrote:
> > Hi,
> >
> > this patch solves WaE unused pDoc parameter in 
> > ScTabViewShell::UpdateNumberFormatter.
> > I have no idea, why I'm getting it now, git blame says that the last 
> > changes in this file were years ago ...
> >
> > Regards
> > David 
>
> Hi, David,
>
> I can't open your attached file.  It has a .swp extension?
>
> I think the warning was a result of 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a774815a24d3f55a64d901a1266e4543a2a2930 
> .
>
> Thomas was removing unused code and looks like removing the 
> ScDocument* pDoc parameter of ScTabViewShell::UpdateNumberFormatter 
> was forgotten.
>
>
> Respectfully,
> Daniel Bankston
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

From 87a43003980eac899c5ec07832abefc3e01d3855 Mon Sep 17 00:00:00 2001
From: David Ostrovsky <David.Ostrovsky@gmx.de>
Date: Thu, 7 Jun 2012 23:59:04 +0200
Subject: [PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

Change-Id: I86b25a21e15ce10c8e6ad350381f4739cb056d3a
---
 sc/source/ui/inc/tabvwsh.hxx   |    3 +--
 sc/source/ui/view/formatsh.cxx |    3 +--
 sc/source/ui/view/tabvwsh5.cxx |    1 -
 sc/source/ui/view/tabvwsha.cxx |    2 +-
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index 5852065..ecf3ebe 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -403,8 +403,7 @@ public:
                                       ScViewData*            pViewData,
                                       SvxNumberInfoItem**    ppItem );
 
-    void    UpdateNumberFormatter   ( ScDocument*               pDoc,
-                                      const SvxNumberInfoItem&  rInfoItem );
+    void    UpdateNumberFormatter   ( const SvxNumberInfoItem&  rInfoItem );
 
     void    ExecuteCellFormatDlg    ( SfxRequest& rReq, sal_uInt16 nTabPage = 0xffff );
 
diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index 98ac665..6690dd5 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -853,8 +853,7 @@ void ScFormatShell::ExecuteStyle( SfxRequest& rReq )
 
                         if ( SFX_STYLE_FAMILY_PARA == eFam )
                         {
-                            pTabViewShell->UpdateNumberFormatter( pDoc,
-                                (const SvxNumberInfoItem&)
+                            pTabViewShell->UpdateNumberFormatter((const SvxNumberInfoItem&)
                                     *(pDocSh->GetItem(SID_ATTR_NUMBERFORMAT_INFO)) );
 
                             pTabViewShell->UpdateStyleSheetInUse( pStyleSheet );
diff --git a/sc/source/ui/view/tabvwsh5.cxx b/sc/source/ui/view/tabvwsh5.cxx
index 7acaa96..5f1d645 100644
--- a/sc/source/ui/view/tabvwsh5.cxx
+++ b/sc/source/ui/view/tabvwsh5.cxx
@@ -413,7 +413,6 @@ void ScTabViewShell::MakeNumberInfoItem( ScDocument*         pDoc,
 //------------------------------------------------------------------
 
 void ScTabViewShell::UpdateNumberFormatter(
-                        ScDocument*              pDoc,
                         const SvxNumberInfoItem& rInfoItem )
 {
     const sal_uInt32 nDelCount = rInfoItem.GetDelCount();
diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index d64de03..4efd093 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -527,7 +527,7 @@ void ScTabViewShell::ExecuteCellFormatDlg( SfxRequest& rReq, sal_uInt16 nTabPage
         if(pOutSet->GetItemState(SID_ATTR_NUMBERFORMAT_INFO,sal_True,&pItem)==SFX_ITEM_SET)
         {
 
-            UpdateNumberFormatter( pDoc,(const SvxNumberInfoItem&)*pItem);
+            UpdateNumberFormatter((const SvxNumberInfoItem&)*pItem);
         }
 
         ApplyAttributes( pOutSet, pOldSet );
-- 
1.7.5.4