Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index 

Hi Daniel,
many thanks! This was some kind to fast forward ;) Didn't see the rInfoItem.GetNumberFormatter()->DeleteEntry() call. 

Thanks! Pushed.

Thomas

On 06/07/2012 06:25 PM, Daniel Bankston wrote:

On 06/07/2012 10:34 AM, Thomas Arnhold wrote:

Hi,

this patch removes some dead code. Please could someone review it,
especially the part at sc/source/ui/view/tabvwsha.cxx, to be sure it's
save.

Thanks!

Thomas



Hi, Thomas,

I'm sure someone more knowledgeable than me will soon reply.  However, I
think that in ScTabViewShell::UpdateNumberFormatter() only the call to
ScDocument::DeleteNumberFormat() should be removed, and the rest should
be left alone.  Of course this also means that the calls to
ScTabViewShell::UpdateNumberFormatter() should not be removed.


Respectfully,
Daniel Bankston

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.