Hi Michael,
* I used a pointer to the vector as the move() function previously
copied and cleared all elements whereas a pointer swap would suffice.
ah that's why, i had wondered....
would it be possible to use std::swap on the vector itself rather than
the pointer? i could imagine that being implemented efficiently, and
it would allow the vector to not be a pointer, which is simpler.
also (but that was a pre-existing condition, not really your fault)
member names should start with "m_" so it's easy to grep for member access.
Ah, I can use vector::swap(). Patch attached getting rid of the vector
pointer. Much nicer.
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.