Re: [PATCH] [REVIEW:3-5] fdo#47473 legacy reports created in 3.5 fail to open

On Wed, Jun 06, 2012 at 06:11:31AM +0200, Lionel Elie Mamane wrote:
> On Tue, Jun 05, 2012 at 10:11:23PM +0200, Lionel Elie Mamane wrote:

> > Legacy reports (not Sun/Oracle Report Builder ones) created by the
> > wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
> > and later): show empty data.

> > Please apply to libreoffice-3-5 branch.

> Wait... I causes a build failure on MOX.

Here's the fix by Norbert. Please apply both the original patch and
the fix. Thanks. (And somebody find me a brown paper bag...)

-- 
Lionel

From f6bc6c351144ae10c29d4747a4c40f80554f272f Mon Sep 17 00:00:00 2001
From: Norbert Thiebaud <nthiebaud@gmail.com>
Date: Tue, 5 Jun 2012 18:14:52 -0500
Subject: [PATCH] fix bug in commit 32c943e161117e4362ac9246baac2c0fb54e7c79

Change-Id: I684fb4adb68d372914ea42cc4e7bd4459a08b150
---
 .../wizards/report/ReportTextImplementation.java   |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/wizards/com/sun/star/wizards/report/ReportTextImplementation.java 
b/wizards/com/sun/star/wizards/report/ReportTextImplementation.java
index 94b4e40..6be5b36 100644
--- a/wizards/com/sun/star/wizards/report/ReportTextImplementation.java
+++ b/wizards/com/sun/star/wizards/report/ReportTextImplementation.java
@@ -291,6 +291,7 @@ public class ReportTextImplementation extends ReportImplementationHelper impleme
                     bexecute = getRecordParser().executeCommand(nCommandType); 
//sMsgQueryCreationImpossible + (char) 13 + sMsgEndAutopilot, sFieldNameList, true);
                     if (bexecute)
                     {
+                        DBMetaData.CommandObject oCommand = 
getRecordParser().getQueryByName(sQueryName);
                         bexecute = getRecordParser().getFields(sFieldNameList, true);
                         if (bexecute && 
getRecordParser().hasEscapeProcessing(oCommand.getPropertySet()))
                         {
-- 
1.7.7.3