Re: [PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

Hi Jan,

On Mon, Jun 4, 2012 at 4:50 PM, Jan Holesovsky <kendy@suse.cz> wrote:

> - changed sal_Bool -> bool (we prefer the native bool in the new code)
I used what other code around was using. If bool is preferred to
sal_Bool maybe the whole bitmap and bitmapex code should be changed to
reflect this. I can do this in a cleanup task for bitmap and bitmapex
as there are also some German comments to translate.

> - modified one method to be void (it always returned true)
OK, I did not pay attention to this.

> - added your real name as the author (please set your git config \
>  --global user.name)
OK changed.

> - and reverted the _LANCZOS use for the PDF export for now - sorry for
>  that; but I am afraid there must be a small glitch somewhere :-(
>
> How did I find out; I told myself "let's be bold, and default to
> Lanczos" ;-) - and tried with the attached 2 patches, but from some
> reason the start screen looks like the attached "start.png" then - can
> you please have a look?
I have also tried this and I think this is related to resizing of
really small images (1px width or height) which Lanczos does not
handle well. In such cases it is probably better to fallback to
bilinear interpolation or "fast". I will have a look and see exactly
is wrong - maybe I can fix this issue.

> Thank you so much for your work - if you can fix that, and ideally add a
> unit test, or few, I am all for enabling it for 3.6 even a bit later as
> a late feature; hopefully we might find 2 more approvals for that :-)
This is great if it could go into 3.6. I will work to fix the issues ASAP.

> All the best,
> Kendy

Best Regards,
Tomaž