[PATCH] disable unit tests wich depend on xmlsec was: sc filter test failures

On 28.05.2012 22:30, Markus Mohrhard wrote:
> Hey,
>
>
> > ./autogen.sh --with-max-jobs=6 --with-num-cpus=3 --without-stlport
> > --without-help --without-helppack-integration --without-myspell-dicts
> > --without-junit --without-java --disable-epm --disable-gconf
> > --disable-opengl --disable-gnome-vfs --disable-librsvg --disable-gtk
> > --disable-gtk3 --disable-odk --disable-vba --disable-mozilla
> > --disable-gstreamer --disable-randr --without-ppds --without-afms
> > --disable-cairo-canvas --disable-neon --disable-dbus --disable-systray
> > --disable-mathmldtd  --disable-extension-integration
> > --disable-postgresql-sdbc --with-system-libs --without-system-libcdr
> > --without-system-libvisio --without-system-boost --without-system-libcmis
> > --without-system-libwpd --without-system-cppunit --without-system-libwps
> > --without-system-libwpg --disable-graphite --without-system-sampleicc
> > --without-system-redland --without-system-hunspell --without-system-mythes
> > --without-system-altlinuxhyph --without-system-lpsolve
> > --without-system-libexttextcat --without-system-poppler
> > --without-system-mdds --without-system-vigra --without-system-odbc
> > --disable-ldap --disable-nsplugin  --without-system-mozilla-headers
> > --without-system-sane --disable-unix-qstart-libpng --disable-xmlsec
> > --disable-cups --without-system-clucene
> The problem is --disable-xmlsec. You should not specify this flag as
> long as you plan to build on a normal platform. Behind xmlsec are also
> all our password related libraries so you can't open password
> protected documents. This option makes only sense for platforms where
> we don't yet support them.
I was getting the same error on feature/gbuild_merge branch and reported 
it here: [1].
I think we should handle this properly: if some feature is disabled, 
unit tests have to be disabled too.
Attached patch does it.

[1] http://lists.freedesktop.org/archives/libreoffice/2012-May/032345.html

Regards
David

From cfd793a26fbc8909bd2ffdce4a87c7d813e3f95f Mon Sep 17 00:00:00 2001
From: David Ostrovsky <David.Ostrovsky@gmx.de>
Date: Mon, 28 May 2012 22:50:41 +0200
Subject: [PATCH] disable unit tests wich depend on xmlsec, if built without
 xmlsec

Change-Id: I6386d77a833cc8a6bd0afc839e8afe283aefa3c8
---
 sc/CppunitTest_sc_filters_test.mk      |    4 ++++
 sc/qa/unit/subsequent_filters-test.cxx |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/sc/CppunitTest_sc_filters_test.mk b/sc/CppunitTest_sc_filters_test.mk
index df24d15..f659f8a 100644
--- a/sc/CppunitTest_sc_filters_test.mk
+++ b/sc/CppunitTest_sc_filters_test.mk
@@ -120,6 +120,10 @@ $(eval $(call gb_CppunitTest_use_components,sc_filters_test,\
 
 $(eval $(call gb_CppunitTest_use_configuration,sc_filters_test))
 
+$(eval $(call gb_CppunitTest_add_defs,sc_filters_test,\
+   -DENABLE_XMLSEC=$(ENABLE_XMLSEC) \
+))
+
 $(eval $(call gb_CppunitTest_use_filter_configuration,sc_filters_test))
 
 # we need to
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index 68b5bf0..31e6911 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -145,10 +145,12 @@ public:
 
     //disable testPassword on MacOSX due to problems with libsqlite3
     //also crashes on DragonFly due to problems with nss/nspr headers
+#if defined(ENABLE_XMLSEC)
 #if !defined(MACOSX) && !defined(DRAGONFLY) && !defined(WNT)
     CPPUNIT_TEST(testPasswordOld);
     CPPUNIT_TEST(testPasswordNew);
 #endif
+#endif
 
 #if TEST_BUG_FILES
     CPPUNIT_TEST(testBugFiles);
-- 
1.7.5.4