Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Fri, May 25, 2012 at 12:07 PM, Stefan Knorr (Astron)
<heinzlesspam@googlemail.com> wrote:
Hi there,

I've always wondered why LibreOffice (and before it Ooo) would make
the selected tab header bold, because no OS I know does that natively.
While there is an option with which backends could turn this behaviour
off, if there's no need for that we probably should remove it, I
guess.
Attached patch does that and even works. Can I push or is there
something that seems wrong?


I'm confused:

@@ -723,9 +705,7 @@ void TabControl::ImplShowFocus()
     // make sure the focussed item rect is computed using a bold font
     // the font may have changed meanwhile due to mouse over

-    Font aOldFont( GetFont() );
-    Font aFont( aOldFont );
-    aFont.SetWeight( (!ImplGetSVData()->maNWFData.mbNoBoldTabFocus) ?
WEIGHT_BOLD : WEIGHT_LIGHT );
+    Font aFont( GetFont() );
     SetFont( aFont );
^^^ you are setting the Font to the same thing it used to have here no
(since you remove the code that used to potentially alter it)?

     sal_uInt16                   nCurPos     = GetPagePos( mnCurPageId );
@@ -771,8 +751,7 @@ void TabControl::ImplShowFocus()
         aRect.Bottom() = aRect.Top() + aImageSize.Height() + 4;
     }
     ShowFocus( aRect );
-
-    SetFont( aOldFont );
+    SetFont( aFont );
 }

Why the last SetFont() ? you are not messing with the font anymore
right ? so it has not changed... no need to restore it, no?

Norbert

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.