Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


See below commit for shrinking size of type rdbs by removing the unused(?) UNOIDL documentation contained within.

I'm really not sure there was a reason to include it in the first place (in the *_doc variants before gbuild'ification, and unconditionally afterwards). If anybody knows about a reason, please do speak up. (Jürgen, do you remember any?)

Otherwise, it might be fine to backport this master commit to libreoffice-3-5, too. (It slightly reduces installation set size. Whether it also improves performance I did not bother to measure---I doubt it makes a noticeable difference on contemporary hardware.)

Stephan

On 05/25/2012 10:54 AM, Stephan Bergmann wrote:
  solenv/gbuild/UnoApiTarget.mk |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3d199e410bda1ba148eed26176e1003df21eaa75
Author: Stephan Bergmann<sbergman@redhat.com>
Date:   Fri May 25 10:27:30 2012 +0200

     Removed documentation from type rdbs

     Before gbuild'ification, solenv/inc/target.mk carefully produced two variants of
     each type rdb, a plain one from calling idlc w/o -C and a *_doc variant from
     calling idlc w/ -C ("generate complete type information, including
     documentation").  After gbuild'ification, solenv/gbuild/UnoApiTarget.mk
     unconditionally only produced "complete" type rdbs from calling idlc w/ -C.

     It is unclear to me whether the old *_doc variants had actually been used for
     anything (what got packaged into installation sets apparently were the plain,
     slim variants; and autodoc apparently does not need the *_doc variants, either,
     as it produces UNOIDL documentation directly from .idl files).  It is also
     unclear to me whether the gbuild switch to effectively package complete, fat
     rdbs was deliberate or not.  (The only client-visible change I see is that low-
     level C/C++ typereg_reader_getDocumentation could now report something.  The
     reflective UNO services at com.sun.star.reflection would not offer access to the
     documenation anyway, however.)

     The benefit of no longer including documentation in the packaged type rdbs is
     size; the URE types.rdb shrinks from 1.2 MiB to 819 KiB, and offapi.rdb shrinks
     from 11 MiB to 6.5 MiB.

     Change-Id: Ib278f74fc3b22169e00a09d778807f8cf58520c4

diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk
index 42584ce..206bbb9 100644
--- a/solenv/gbuild/UnoApiTarget.mk
+++ b/solenv/gbuild/UnoApiTarget.mk
@@ -58,7 +58,7 @@ define gb_UnoApiPartTarget__command
        RESPONSEFILE=$(call var2file,$(shell $(gb_MKTEMP)),500,\
                $(INCLUDE) \
                -M $(basename $(call gb_UnoApiPartTarget_get_dep_target,$(dir $(2)))) \
-               -O $(call gb_UnoApiPartTarget_get_target,$(dir $(2))) -verbose -C \
+               -O $(call gb_UnoApiPartTarget_get_target,$(dir $(2))) -verbose \
                $(sort $(patsubst $(call 
gb_UnoApiPartTarget_get_target,%.urd),$(SRCDIR)/%.idl,$(3))))&&  \
        $(gb_UnoApiPartTarget_IDLCCOMMAND) @$${RESPONSEFILE}>  /dev/null&&  \
        rm -f $${RESPONSEFILE}&&  \
_______________________________________________
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.