Re: [Libreoffice-commits] .: 6 commits - configure.in i18npool/Library_i18npool.mk solenv/gbuild

On 17/05/12 07:35, David Tardon wrote:
> On Wed, May 16, 2012 at 03:00:33PM -0700, Michael Stahl wrote:
> >  $(call gb_Extension_get_rootdir,$(1))/$(2) : $(gb_Extension_HELPEXTARGET)
> > -$(call gb_Extension_get_rootdir,$(1))/$(2) : $(3)
> > +$(call gb_Extension_get_rootdir,$(1))/$(2) : $(3) $(gb_Extension_HELPEXTARGET)
>
> Ehm, the dependency on $(gb_Extension_HELPEXTARGET) is already there .-)

d'oh, clearly it should have been written in a bigger font for blind me
to notice  :)

> > commit 07c0b800d9d70857882238204820f75b8dc98b26
> > Author: Michael Stahl <mstahl@redhat.com>
> > Date:   Wed May 16 13:48:37 2012 +0200
> >
> >     fix spurious re-delivery of RDB files:
> >     
> >     The OUTDIR RDB depends on Packages for IDL and headers, the latter of
> >     which depends on the WORKDIR RDB, hence preserving timestamps here leads
> >     to spurious re-delivery because the OUTDIR RDB always has older
> >     timestamp than the headers Package.
>
> Actually, these dependencies could (should) be replaced by order-only
> dependencies. They are only there to ensure the headers and IDL files
> are delivered properly.

you are absolutely right, why didn't i think of it (while funnily fixing
the i18npool problem in exactly this way), thanks for noticing.