Hi, we need two more approvals for http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=619b692dfd5c19fb7de344d25bcbb8689e5dc940 for 3-5-4 branch. It fixes build error on Windows: --- cut --- vbamodule.o : error LNK2019: unresolved external symbol "__declspec(dllimport) bool __cdecl sfx2::isValidNCName(class rtl::OUString const &)" (__imp_?isValidNCName@sfx2@@YA_NABVOUString@rtl@@@Z) referenced in function "bool __cdecl sfx2::isValidXmlId(class rtl::OUString const &,class rtl::OUString const &)" (?isValidXmlId@sfx2@@YA_NABVOUString@rtl@@0@Z) c:/onegit/workdir/wntmsci12.pro/LinkTarget/Library/ooxlo.dll : fatal error LNK1120: 1 unresolved externals --- cut --- Another solution would be to do not inline isValidXmlId see http://opengrok.libreoffice.org/xref/core/sfx2/inc/sfx2/XmlIdRegistry.hxx#50 that calls isValidNCName. This header is included indirectly via filter/msfilter/msvbahelper.hxx that was added via http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=4dc7a53b066c0241fc55b41b41d57a690ca512b1 Well, when we include headers from sfx2, it would make sense to link it as well. Best Regards, Petr