Re: [PATCH] fdo#43209 - Implement line cap butt, round and square as defined in ODF 1.2

Hi Regina,

On Wed, 2012-05-16 at 13:40 +0200, Regina Henschel wrote:
> The patch brings the line cap feature from AOO3.4 to LO3.6. It is 
> technical correct (hopefully). The whole patch is under Apache License 
> 2.0. The patch is not completely done by me, but second author is Armin 
> Le Grand, Armin.Le.Grand@me.com. Does a way exists to honor two authors 
> in the author-field?

        We tend to prefer each author to have their commits under their own
name, wherever possible. Is that the case in the Apache / svn repo ?

> Compared to AOO3.4 I had to make some minor technical changes to get it 
> apply-able to LO3.6, e.g. sal_Bool -> bool.

        Great.

> The two new files svx/inc/svx/xlncapit.hxx and 
> offapi/com/sun/star/drawing/LineCap.idl have got Apache License 2.0 
> headers. I don't know whether this has to be changed to another header.

        Unfortunately, until we can clarify the authorship of all of our
commits that touch  the files that this patch applies to: something that
I'm actively working on, as you know (you might have seen a number of
statements on this list in recent days :-) - merging code from the
Apache project is not possible *unless* we get an explicit MPL/LGPLv3+
dual-license on record.

        I can imagine Armin has problems getting that statement ;-) IBM is not
an enthusiastic contributor to LibreOffice sadly, and as such we have to
treat this very carefully.

        That sucks ! however, I'm fully aware of the feature-freeze coming up,
and I'm working hard to get the ground work done, so that your lovely
feature can be included for 3.6 :-) [ and yes the delay, and the burning
away of my life that this work creates is not appreciated - but it's not
my fault ;-].

        Hope that helps,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot