Re: [PATCH] Release notes: use bug titles instead of commit messages if possible

Hi Ivan,

It is great idea. I am sorry for the late replay. I have somehow missed
this mail.

Ivan Timofeev píše v Čt 10. 05. 2012 v 21:04 +0400:
> Hi,
>
> looking at our release notes
>    http://wiki.documentfoundation.org/Releases/3.5.3/RC1
> I think it is confusing for users to see the git commit messages there.
> For example:
>    clrContourCache for SwAnchoredDrawObjects (fdo#45376) [Andreas Schierl]

I fully agree.

> What about using the bug names? Mozilla does the same:
> http://www.mozilla.org/en-US/firefox/11.0/releasenotes/buglist.html

Yup, such list of fixed bugs makes perfect sense.

> The rough patch for bin/lo-commit-stat is attached. (But please note, 
> that I am an absolute Perl n00b. :)
> Unfortunately it does not work with Novell bugzilla. :(
>
> Refusals? Thoughts? Advices?

The first draft is cool! I would just slightly modify the logic. I see
the following problems:

        + some commits fix more bugs; your solution returns summary of
          the last one
        + there might be more commits for the same bug; you might get
          more exactly same lines
        + sometimes the bug description is lame as well :-)

What about the following solution? lo-commit-stat already has three
basic modes where it prints:

        + all commit messages by default
        + only commit massages with bug numbers when used --bugs
        + only bug numbers when used --bug-numbers

I would leave the default mode as is. I would rework --bugs mode to
behave more like the --bug-numbers mode. It should print all bug numbers
together with the messages from bugzilla. If you are not able to get the
bug title, it might print the commit message instead.

Hmm, the current --bug-numbers mode is an ugly quick hack. It does not
look for duplicates. It would be better to rewrite it a bit. I would put
bug numbers into a hash in load_git_log(). Then you could implement
print_bugs() instead of print_stat() and just go though this hash and
print it different way (one line per bug instead of one line per
commit).

How does that sound?

Would you like to look at it? If you do not feel like, I could do the
refactoring myself. You already did the great job to find how to get
bugzilla titles.


Best Regards,
Petr