Re: [REJECTED][PATCH]calc and row height for numerical cells with text wrap

Hi all,

we had this discussion before. Line break is very useful for date 
values. So please consider
https://issues.apache.org/ooo/show_bug.cgi?id=118841

with kind regards
Regina

Eike Rathke schrieb:
> Hi Laurent,
>
> On Monday, 2012-05-14 17:30:47 +0200, Laurent Godard wrote:
>
> > Here is a small patch that tend to address the following problem
> >
> > a row set to optimal height
> > a cell containing a value
> > formated with # ###,00
> > vertically centered
> > and text wrapping allowed
> >
> > actually the row height is not adjusted
> >
> > The patch removes the test on "numerical cell".
> >
> > Then, now the row height of the formatted cell is correct when the
> > text is wrapped over lines (may be some confusion with line break
> > versus text wrapping regarding ATTR_LINEBREAK)
>
> Those lines were added by Kohei as a fix for
> https://issues.apache.org/ooo/show_bug.cgi?id=111387
> I think we should not remove them.
>
> In fact the display string should not be wrapped at all, displaying
> 12345,6789 as
>
> 12 34
>   5,68
>
> isn't very sensible.
>
>    Eike
>
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice