Re: [SOLVED] build error with poppler 0.20.0

On 14-05-2012 16:07, Petr Mladek wrote:
> Gökçen Eraslan píše v Ne 13. 05. 2012 v 21:51 +0300:
> > On 13-05-2012 21:09, Andreas Radke wrote:
> > > ArchLinux is moving to poppler 0.20.0 that breaks LibO build:
> > >
> > > [ build CXX ] svl/source/misc/sharecontrolfile
> > > /build/src/libreoffice-core-3.5.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In 
> > > member function 'int pdfi::PDFOutDev::parseFont(long long int, GfxFont*, GfxState*) const':
> > > /build/src/libreoffice-core-3.5.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:406:28:
> > > error: 'class GfxFont' has no member named 'getOrigName'
>
> > Can you try changing getOrigName to getName? It seems function name is
> > changed to getName[1].
>
> Ionut provided nice patch, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=704f3155cca2e1fb5ad071539b7f8b5e5522dd97
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=ac68934592ec7d838cf5c22744be8d97aa4a1a47

GooString* pFamily = gfxFont->getName();
if( ! pFamily )
    #if POPPLER_CHECK_VERSION(0, 20, 0)
        pFamily = gfxFont->getName();
    #else
        pFamily = gfxFont->getOrigName();
    #endif

Is it all right to call getName() second time if pFamily is null and
poppler is 0.20?

> Best Regards,
> Petr
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Gökçen Eraslan

Attachment: signature.asc
Description: OpenPGP digital signature