Re: Regarding your commit: Add all the available themes to the list

Hello Tomas,

On Wed, May 2, 2012 at 1:54 AM, Tomáš Chvátal <tomas.chvatal@gmail.com> wrote:
> Ok I will remove them from the global list again.

For a record, the commit is [1]. But may I nag you again? :-)

First, I don't think we should have 'classic' or 'industrial' theme in
the list, as I said in previous message.
I just tried again, building with all supported themes including
'classic' and 'industrial', and the result is that: in Tools > Options
> View > There are only 6 themes in the option list -- without
'classic' and 'industrial' at all.
So, I think it's no use to have an option to build with these two killed themes.

Second nitpick, your commit message:
> There is no visible difference on: --with-themes=galaxy or --with-themes=default
But I think it will error when you configure --with-theme=galaxy,
right? (see the code)

Last nitpick, in configure.in:978, the 'crystal' theme should have an
asterisk * :-)

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=ffc198fb645f13a14e64eeb4e7067c42e97f4b63

Thanks :-)
Best Regards,
-- 
Korrawit Pruegsanusak