Re: [PATCH] gbuild conversion: registry module

Hi David,

On 5 May 2012 00:21, David Ostrovsky <david.ostrovsky@gmx.de> wrote:
> I have some questions to this patch:
>
> 1.
> Test and workben directories are not used: let the old makefiles in place?

Either that or remove the directories completely.
I've been keeping them untouched.

> 2.
> What is this for:
> CDEFS += -DDLL_VERSION=$(EMQ)"$(DLLPOSTFIX)$(EMQ)"

probably nothing

> 3.
> Where these versions are used?
> .INCLUDE :  ..$/version.mk

nowhere I guess

> 4. Have no idea what is this for => ignored ;-)
> makedocpp: $(DOCPPFILES)
>     docpp -H -m -f  -u -d $(OUT)$/doc$/$(PRJNAME) $(DOCPPFILES)

hmm, this is probably useless, so ok to ignore

> 5. how to handle this?
> TARGET=reg
> [...]
> .IF "$(COM)" == "MSC"
> SHL1IMPLIB= ireg
> .ELSE
> SHL1IMPLIB= $(TARGET)
> .ENDIF

You don't need to do anything about this.
'i' prefix is default for .lib file. Otherwise you would need to touch
RepositoryFixes.mk.

Your patch looks good, only few comments:
 - AFAICS rdbedit is not delivered so can't be used (see prj/d.lst)
 - there was no regcpp library, only archive used to create reg
library (which is already registered)
     -> I think that it has worked for you because you have not done
build from clean ?
- maybe registry_helper could be called registry_common or just
registry ? But I don't care too much.

Otherwise it could be good, though I can't get it build on windows and
it does not print reasonable error.
ireg.lib is missing but I don't know why.

Thanks,
Matus