On 03/05/12 19:15, Muhammad Haggag wrote:
On Thu, May 3, 2012 at 11:24 AM, Michael Stahl <mstahl@redhat.com> wrote:
sorry for taking so long, but i had hoped that somebody else would
perhaps be more familiar with table autoformats and review this rather
substantial patch :)
No problem. I'm improving my knowledge of AutoFormats and documenting
it as I go, so hopefully it'll become clearer to anyone who reads the
code.
ah yes, those comments you added are great as well :)
i did some trivial tweaks to your patch, to follow our coding standards
added an m_ prefix to all new member variables, which makes things much
easier to read (because with the implicit "this" you never know what
kind of side-effects an assignment has); also i've split out the Undo
thing into a separate commit.
Cool. I actually tried to follow the convention that already existed
in the code. I prefer member variable prefixes as well. (I have no
clue what the 'a' prefix means).
the "a" prefix probably means "anything for which no more specific
prefix exists", and as such i consider it almost completely useless.
Is there an official style guideline somewhere?
the Writer team had one back on the OOo wiki:
http://wiki.services.openoffice.org/wiki/Writer/Code_Conventions
seems still relevant, except for some things like "our_" prefix which
i've never seen in actual code, git grep says it's mostly used in
bookmark code so it's entirely obvious who simply made that up and added it.
also this:
http://wiki.services.openoffice.org/wiki/Cpp_Coding_Standards
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.