Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On Mon, Apr 30, 2012 at 1:24 PM, Michael Meeks <michael.meeks@suse.com> wrote:
Hi Gabor,

On Sun, 2012-04-29 at 04:56 +0200, Gábor Stefanik wrote:
This enables overriding icons found in an images.zip file with ones in
a directory named "images" next to the zip file.

       Looks lovely, as/when there are dev-builds we should poke the artists
about it so they know it's there & get them excited about it :-)

Icon caching is also disabled when a lookaside directory is detected,
so changes to the icons in the directory are applied immediately.

       So - one minor problem here is that, we do this system-call thrash for
each icon for a file that is not there :-) I'd rather prefer that we
require the images/ directory to exist at startup - if it is there, we
always do the lookups first in there and turn the cache off - otherwise,
we never look in there.

       Any chance of a minor follow-on tweak to do that ? the strace of a
normal startup without that directory should not have scads of opens
of .pngs.

Will post a patch for this, thanks for the heads up.


Icons in a lookaside directory currently always take precedence over
ones in zip files.

       Thanks for that, can you close the easy-hack bug too ? :-)

Will do.


       Nice work,

               Michael.

--
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


--Gábor

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.