Re: [PUSHED] Re: [PATCH] EasyHack #32621 - More robust ExternalMailer support

On Mon, Apr 30, 2012 at 12:23 PM, Dave Steele <dsteele@gmail.com> wrote:
> On Mon, Apr 30, 2012 at 9:57 AM, Jan Holesovsky <kendy@suse.cz> wrote:
> > ...
> > So I guess that is for the case the user writes something broken into
> > the mailer setting, which results in non-working sending of email.
>
>
> No. This is for the case where the user has a valid mailer selected
> which is not specifically supported by senddoc - in my case
> gnome-gmail.

I don't think this tweak to the patch is correct.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f0208e344b2500e9338885e6177dd2c4f52c6373


diff --git a/shell/source/unix/misc/senddoc.sh
b/shell/source/unix/misc/senddoc.sh
index 692930e..f3657e6 100755
--- a/shell/source/unix/misc/senddoc.sh
+++ b/shell/source/unix/misc/senddoc.sh
@@ -400,6 +400,10 @@ case `basename "$MAILER" | sed 's/-.*$//'` in
;;
*)
+ # The user has tweaked the email settings, and configured something we
+ # do not recognize. Try to be smart, and send the mail anyway, if we
+ # have the possibility to do so.
+
if [ -x /usr/bin/gnome-open ] ; then
MAILER = /usr/bin/gnome-open
elif [ -x /usr/bin/xdg-open ] ; then